-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Branch - Full Node Streaming into protocol/v6.x
#2273
base: release/protocol/v6.x
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
||
subaccountIds = append(subaccountIds, &satypes.SubaccountId{ | ||
Owner: parts[0], | ||
Number: uint32(number), |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
strconv.Atoi
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 5 days ago
To fix the problem, we need to ensure that the parsed integer value is within the bounds of uint32
before converting it. This can be achieved by using strconv.ParseUint
with a specified bit size of 32, which directly parses the string into a uint32
value. This approach avoids the need for additional bounds checking and ensures that the value is within the valid range for uint32
.
-
Copy modified line R117 -
Copy modified line R140
@@ -116,3 +116,3 @@ | ||
|
||
number, err := strconv.Atoi(parts[1]) | ||
number, err := strconv.ParseUint(parts[1], 10, 32) | ||
if err != nil { | ||
@@ -139,3 +139,3 @@ | ||
for _, idStr := range idStrs { | ||
id, err := strconv.Atoi(idStr) | ||
id, err := strconv.ParseUint(idStr, 10, 32) | ||
if err != nil { |
if err != nil { | ||
return nil, fmt.Errorf("invalid clobPairId: %s", idStr) | ||
} | ||
clobPairIds = append(clobPairIds, uint32(id)) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
strconv.Atoi
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 5 days ago
To fix the problem, we should replace the use of strconv.Atoi
with strconv.ParseUint
, specifying a bit size of 32. This ensures that the parsed value is within the bounds of uint32
. Additionally, we should add bounds checking to handle cases where the parsed value exceeds the uint32
range.
-
Copy modified line R140
@@ -139,3 +139,3 @@ | ||
for _, idStr := range idStrs { | ||
id, err := strconv.Atoi(idStr) | ||
id, err := strconv.ParseUint(idStr, 10, 32) | ||
if err != nil { |
22525f9
to
fe0d727
Compare
Cherry picks all full node streaming code changes from main into the protocol/v6.x branch.