Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on the WoT Integration guide and blog post #1332

Closed
egekorkan opened this issue Mar 8, 2022 · 1 comment · Fixed by #1334
Closed

Feedback on the WoT Integration guide and blog post #1332

egekorkan opened this issue Mar 8, 2022 · 1 comment · Fixed by #1334

Comments

@egekorkan
Copy link

While reading https://www.eclipse.org/ditto/basic-wot-integration.html and https://www.eclipse.org/ditto/2022-03-03-wot-integration.html I have spotted some issues which are borderline nitpicky:

Guide:

if backed by a WoT Thing Model, the twin will tell you as response exactly
what it is capable of
which HTTP endpoints to invoke to access data / send messages

I do not understand what is meant by the response. Also, TMs do not necessarily have HTTP endpoints and this documentation even says that at https://github.com/eclipse/ditto/blob/6ebbe7e2da9c7f82405ab7676c1f43358d464eba/documentation/src/main/resources/pages/ditto/basic-wot-integration.md?plain=1#L54

Blog Post:

@thjaeckle
Copy link
Member

Thx for the awesome feedback, @egekorkan - will incorporate it 👍

thjaeckle added a commit to bosch-io/ditto that referenced this issue Mar 11, 2022
…ation

* also replaced links to the spec to the now published "WoT TD W3C Working Draft 11 March 2022" to have an immutable version

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
thjaeckle added a commit that referenced this issue Mar 11, 2022
[#1332] incorporated feedback on WoT blogpost + documentation
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants