Fix that wrong metadata in search updater causes patch failure #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug * on recovery of ThingUpdater, the "thingRevision" of Metadata was set hard to "-1" - this caused always a failed patch update * fix is to restore the metadata from the read search index entry * added better logging for bulk update results: included a correlationId for the bulk + differ between "Success" and "IncorrectPatch" * enhanced existing testcase in ThingUpdaterTest to also test the lookup based recovery of the search index document and assert that revisionNumber is the expected one Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…sumed in ThingUpdater to quickly shut it down Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Yannic92
approved these changes
Feb 10, 2022
Yannic92
deleted the
bugfix/search-wrong-metadata-causes-patch-failure
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading the search index after initialization of the ThingUpdater, the metadata was not updated accordingly to the retrieved data, but the revision was kept at
-1which caused the next update to be a full update and also fail all other changes included in a bulk write.This bugfix fixes that.