Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt error propagation of tunnel errors #1312

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

stmaute
Copy link
Contributor

@stmaute stmaute commented Feb 16, 2022

Propagate all errors to the parent actor in case the SSH tunnel failed.
Adapt connecting-min-timeout to 50s because this timeout needs to be smaller than ditto.connectivity.connection.client-actor-ask-timeout in connectivity.conf which is currently 55s.

Stefan Maute added 2 commits February 15, 2022 10:44
configure connecting-min-timeout to 50s because this timeout needs to be smaller than ditto.connectivity.connection.client-actor-ask-timeout;

Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
@thjaeckle thjaeckle added this to the 2.4.0 milestone Feb 16, 2022
Copy link
Contributor

@dguggemos dguggemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stmaute stmaute merged commit 255bbf2 into eclipse-ditto:master Mar 2, 2022
@stmaute stmaute deleted the bugfix/ssh-reconnect-error branch March 2, 2022 10:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants