Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed placeholder resolvment in "commandHeaders" of "ImplicitThingCreation" mapper #1328

Merged

Conversation

thjaeckle
Copy link
Member

  • they were only resolved when the thingTemplate contained any placeholders

  • also added additional placeholder resolvers for resolving "time:" and "request:subjectId" (useful for inline policy)

  • added the missing documentation for the "ImplicitThingCreation" mapper options

  • also added Time + Request placeholder resolvers to RawMessageMapper's header mapping

@thjaeckle thjaeckle added this to the 2.4.0 milestone Mar 2, 2022
…ation" mapper

* they were only resolved when the thingTemplate contained any placeholders
* also added additional placeholder resolvers for resolving "time:" and "request:subjectId" (useful for inline policy)
* added the missing documentation for the "ImplicitThingCreation" mapper options
* also added Time + Request placeholder resolvers to RawMessageMapper's header mapping

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
@thjaeckle thjaeckle force-pushed the bugfix/resolve-command-headers branch from d6e56ee to ea9f0ba Compare March 2, 2022 14:40
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Copy link
Contributor

@DerSchwilk DerSchwilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good finding

@thjaeckle thjaeckle merged commit e01eed3 into eclipse-ditto:master Mar 3, 2022
@thjaeckle thjaeckle deleted the bugfix/resolve-command-headers branch March 3, 2022 08:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants