Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indexing of arrays and enable it by default #1396

Merged
merged 9 commits into from
Jun 22, 2022
Merged

Fix indexing of arrays and enable it by default #1396

merged 9 commits into from
Jun 22, 2022

Conversation

yufei-cai
Copy link
Contributor

  • Choose operator based on wire version of the MongoDB server.
  • Array indexing will continue to work for MongoDB versions below 5.0. It is more efficient for 5.0 or above.

dguggemos and others added 7 commits May 27, 2022 17:10
@dguggemos @yufei-cai
added test to reproduce "Unrecognized expression '$setField'" error
25ecaaf 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
@yufei-cai
Remove ineffective test; allow specifying versions in MongoDbResource…
d5986cf 
…; fix BsonDiffVisitorIT.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Turn off array indexing by default because it only works for MongoDB …
66fb5f4 
…> 5.0.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Fix docker cleanup step ordering of BsonDiffVisitorIT.
2c82756 
Docker client was terminted before containers were.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Use $unsetField only for MongoDB 5.0 or above; turn on array indexing…
e1a415b 
… by default.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Merge branch 'master' into bugfix/bsondiff-setfield
d7cbff0 
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Fix search actor paths in documentation; fix deserialization of Updat…
bc6b253 
…eThing.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@thjaeckle thjaeckle added this to the 2.5.0 milestone Jun 13, 2022
@dguggemos
add note about the effect of modifyConfig command on background sync
586d371 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
@dguggemos
run BsonDiffVisitorIT against MongoDB v4 and v5
667c557 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
@dguggemos dguggemos merged commit ff17c53 into eclipse-ditto:master Jun 22, 2022
@dguggemos dguggemos deleted the bugfix/bsondiff-setfield branch June 22, 2022 11:00
@thjaeckle thjaeckle modified the milestones: 2.5.0, 3.0.0 Jul 4, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yufei-cai @thjaeckle @dguggemos