Extending metadata support #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…hdevcloud.com/bosch-iot-things/ditto into feature/complete-basic-metadata
introduced MetadataWildcardValidator and GetMetadataWildcardResolver for handling wildcards in get-metadata header; implemented retrieving metadata via 'get-metadata' header; add unit tests; fix some typos; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
extend DefaultDittoHeadersBuilderTest for get-metadata header; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
add javadoc to MetadataWildcardValidator; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
added DittoHeaderNotSupportedExceptionTest; changed since annotation to 2.5.0; extract metadata from thing in CreateThing command in constructor to be able to use the functionality also in the tests; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
add handling for 'delete-metadata' header to AbstractDittoHeaders and AbstractDittoHeadersBuilder; adjusted javadoc; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
add unit tests; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…esDeletedStrategyTest because metadata for delete events in now also deleted; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
refactor and resolve sonar issues in MetadataFieldsWildcardResolver; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
check if multiple metadata headers are present and a throw exception in that case; add unit test; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…ng of existing metadata fields; add unit test; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…ng for metadata; extend DittoCachingSignalEnrichmentFacade to handle metadata properly; extend SearchActorIT with searching for metadata; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
… into feature/complete-basic-metadata
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
… into feature/complete-basic-metadata
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
allow leaf wildcard syntax for feature property based commands; extended tests; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…stenceActorTest; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
remove metadata when attributes or features are modified and parts of it are removed; add unit test; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
… into feature/complete-basic-metadata
…adata; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…hdevcloud.com/bosch-iot-things/ditto into feature/complete-basic-metadata
…tedStrategyTest; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…account for new paths when using wildcards Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
adapt merging of thing in MetadataFromCommand; adapt unit tests; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
adapt basic-metadata.md docu; Signed-off-by: Stefan <stefan.maute@bosch.io>
filter out empty objects when deleting metadata; add unit test; Signed-off-by: Stefan <stefan.maute@bosch.io>
Signed-off-by: Stefan <stefan.maute@bosch.io> # Conflicts: # concierge/service/src/main/java/org/eclipse/ditto/concierge/service/common/ConciergeConfig.java # documentation/README.md # internal/models/signalenrichment/src/test/java/org/eclipse/ditto/internal/models/signalenrichment/DittoCachingSignalEnrichmentFacadeTest.java # things/service/src/main/java/org/eclipse/ditto/things/service/persistence/actors/strategies/commands/AbstractThingCommandStrategy.java # things/service/src/test/java/org/eclipse/ditto/things/service/persistence/actors/PersistenceActorTestBase.java # things/service/src/test/java/org/eclipse/ditto/things/service/persistence/actors/ThingPersistenceActorTest.java # thingsearch/model/src/main/java/org/eclipse/ditto/thingsearch/model/SearchModelFactory.java # thingsearch/model/src/main/java/org/eclipse/ditto/thingsearch/model/SearchResult.java # thingsearch/model/src/main/java/org/eclipse/ditto/thingsearch/model/SearchResultBuilder.java # thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/starter/actors/SearchRootActor.java
Signed-off-by: Stefan <stefan.maute@bosch.io> Signed-off-by: Stefan <stefan.maute@bosch.io>
Signed-off-by: Stefan <stefan.maute@bosch.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request some of the open metadata issues are addressed, e.g. put-metadata is supported on sub-resources, metadata can now be deleted and retrieved.
Fixes #772
Fixes #779
Fixes #829
Fixes #884
Fixes #1146
Fixed #1404