Eliminate Concierge service #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
* Moved logic out of model. Handling of resolving the default namespace is only relevant in edge services and from then on the namespace counts as resolved Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
…dency from ditto-connectivity-api Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
This reverts commit 061fa0f. Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
* Sometimes the cache was not invalidate because the policyIdForEnforcement was null while policyEnforcer wasn't * I removed this "duplication" of the policy ID since it can be extracted from the policyEnforcer anyway. This way it can't happen that the two variables are out of sync Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
…o PreEnforcement Adds ExistenceChecker for validating ModifyCommands which optionally create a new entity. Remove BlockeNamepsaceEnfrorcer from connectivity, since not needed. Moves PreEnforcer classes to own package pre_enforcement. Signed-off-by: David Schwilk <david.schwilk@bosch.io>
…d usages Signed-off-by: David Schwilk <david.schwilk@bosch.io>
…feature/concierge-removal
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
* Was overly specific and not required Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
from the shard region Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
…oud.com/bosch-iot-things/ditto into feature/concierge-removal
…arder Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
…oud.com/bosch-iot-things/ditto into feature/concierge-removal Signed-off-by: David Schwilk <david.schwilk@bosch.io>
* changed signature of PreEnforcer to directly use `Signal` for converting/enforcing * added suffix "PreEnforcer" for all classes implementing PreEnforcer * removed "id-cache" from enforcement config * removed no longer needed PolicyEnforcerRetrieverFactory * adjusted package name from "pre_enforcement" to just "pre" * added missing javadocs for public classes * added missing "final" declaration for classes effectively final * some formatting Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…y not enforced at all Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
…oud.com/bosch-iot-things/ditto into feature/concierge-removal
* also adjust changed piggyback "names" Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…f a Policy * only if the Policy semantically changed (e.g. subjectIds or resources were changed) * that causes that many cache invalidations do not need to happen for use cases which modify a Policy in a way which does not change enforcement outcome * also renamed AbstractEvent.appendPayloadAndBuild to appendPayload - because the method does not build, it just appends to the builder Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
thjaeckle
approved these changes
Jul 29, 2022
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Yannic92
force-pushed
the
feature/concierge-removal
branch
from
1aa7eea
to
6cdb35f
Compare
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…picmp excludes accordingly Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…g into account Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
This reverts commit 939fd55.
…usted japicmp excludes accordingly" This reverts commit 15f6be0.
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
thjaeckle
force-pushed
the
feature/concierge-removal
branch
from
1ed03fe
to
cce76fc
Compare
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request targets what is discussed in #1339.
Resolves #1339
The concierge service will be eliminated and authorization of signals are moved to the entity services.
Furthermore we introduced a common extension mechanism based on Akka's Extensions.
All points that could make sense to be extended are converted to a DittoExtensionPoint.