Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer UI: add local_ditto_ide and ditto_sanbdox environments #1422

Merged

Conversation

thjaeckle
Copy link
Member

  • add support for header "x-ditto-pre-authenticated" for local environment

@thfries could you please have a look if those additions/changes are OK?

* add support for header "x-ditto-pre-authenticated" for local environment

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
@thjaeckle thjaeckle changed the title Ditto-UI: add local_ditto_ide and ditto_sanbdox environments Explorer UI: add local_ditto_ide and ditto_sanbdox environments Jul 29, 2022
@thjaeckle thjaeckle added this to the 3.0.0 milestone Jul 29, 2022
@thfries
Copy link
Contributor

thfries commented Jul 29, 2022

Thanks for the update! Glad to see these extensions.

Shall I add the new authentication method to the authorization modal or in the environment settings? Up to now every parameter of an environment can be changed somewhere in the UI (except solutionId). But that can be done independently afterwards.

* made modal a little wider
* harmonized layout

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
@thjaeckle
Copy link
Member Author

Shall I add the new authentication method to the authorization modal or in the environment settings? Up to now every parameter of an environment can be changed somewhere in the UI (except solutionId). But that can be done independently afterwards.

Good idea - I enhanced the authorization modal in that way.

Copy link
Contributor

@thfries thfries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks good, looking forward to see that.
(I am not able to check out the branch of this PR, right? Or is there a way to get that branch to my fork?)

@thjaeckle
Copy link
Member Author

Thanks! Code looks good, looking forward to see that. (I am not able to check out the branch of this PR, right? Or is there a way to get that branch to my fork?)

You could by checking it out via the "bosch-io" fork, the branch is public available here:
https://github.com/bosch-io/ditto/tree/ui-add-ide-and-sandbox-environment

@thjaeckle thjaeckle merged commit cfe0c49 into eclipse-ditto:master Aug 1, 2022
@thjaeckle thjaeckle deleted the ui-add-ide-and-sandbox-environment branch August 1, 2022 13:14
@thjaeckle thjaeckle added the UI Issues related to the Ditto explorer UI label Aug 16, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to the Ditto explorer UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants