Improve test stability #1423
Merged
Improve test stability #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yufei-cai
commented
Jul 29, 2022
yufei-cai
commented
- Use the configured write consistency for all Ditto pubsub updates
- Remove write consistency field from Ditto pubsub requests
- ThingUpdater: delay weak acknowledgements to the end of the next persistence operation
- Do not terminate ThingUpdater after max-idle-time when the actor is not idle
- Do not schedule clock ticks in ThingUpdater in the absence of incoming updates
Reason: Event metadata computation has side effects including sending weak acknowledgements that should not happen until after persistence completes. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
… from ddata config. Reason: Write consistency was not guaranteed in the presence of parallel requests. Example: Start with state S0. Request R1 changes state to S1 with local write concern. Local write succeeds. Request R2 changes state to S1 from S0, but with write concern ALL. Request R2 is considered NOOP, no cluster write is initiated. Request R2 is acknowledged immediately before cluster write happens. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Yannic92
approved these changes
Aug 1, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.