Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JsonWebTokens with an EC keyType #1432

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

DerSchwilk
Copy link
Contributor

Prior the deserialization of an Eliptic Curve JsonWebToken failed, because Ditto assumed it to be an RSA token and missed the modulus and exponent information.

Signed-off-by: David Schwilk david.schwilk@bosch.io

Prior the deserialization of an Eliptic Curve JsonWebToken failed, because Ditto assumed it to be an RSA token and missed the modulus and exponent information.

Signed-off-by: David Schwilk <david.schwilk@bosch.io>
@DerSchwilk DerSchwilk changed the title Add support for JsonWebTokes with an EC keyType Add support for JsonWebTokens with an EC keyType Aug 8, 2022
@thjaeckle thjaeckle added this to the 3.0.0 milestone Aug 9, 2022
Stefan added 2 commits August 10, 2022 10:45
get curve type from JsonWebKey and instantiate ECGenParameterSpec accordingly;
add new JwkException and JwkInvalidException;
adapt exception handling in DittoPublicKeyProvider in case there are missing mandatory fields in the JsonWebKey;
add unit test;

Signed-off-by: Stefan <stefan.maute@bosch.io>
Signed-off-by: Stefan <stefan.maute@bosch.io>
Copy link
Contributor

@stmaute stmaute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@stmaute stmaute merged commit 2649b1b into eclipse-ditto:master Aug 15, 2022
@stmaute stmaute deleted the bugfix/ec-jwt branch August 15, 2022 05:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants