Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disconnecting state not shown in connection status for MQTT connection #1439

Conversation

dguggemos
Copy link
Contributor

No description provided.

Kalin Kostashki and others added 7 commits July 28, 2022 15:57
…etrying

 - added logic to getClientDisconnectedListener() to send ReportConnectionStatus with the disconnect cause. This will ensure that an open SSH tunnel with a disconnecting MQTT client will have a better representation >> SSH == OPEN and MQTT == Disconnecting
 - made sure to propagate ConnectivityStatus.OPEN when MQTT is connected

Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.io>
…Success

 - The ReportConnectionStatusError will send only the throwable to the BaseClientActor in order to pass on the error in statusDetails.
 - The ReportConnectionStatusSuccess is only a marker to trigger updateConnectionStatusSuccess()
 - also fixed a few places where inConnectionStatusSince wasn't properly updated

Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.io>
…ed disconnect

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…ting

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…nnectionStatus

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…nnectionStatus

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…nect method)

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
@dguggemos dguggemos merged commit bc86674 into eclipse-ditto:master Aug 10, 2022
@dguggemos dguggemos deleted the bugfix/disconnecting-state-not-shown-in-connectionStatus branch August 10, 2022 12:36
@thjaeckle thjaeckle added this to the 3.0.0 milestone Aug 11, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants