Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer UI - Fix: Avoid storing credentials #1464

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

thfries
Copy link
Contributor

@thfries thfries commented Aug 28, 2022

Hello @thjaeckle,

as discussed, please find a fix to avoid that credentials are stored.

Thomas

Signed-off-by: thfries <thomas.fries0@gmail.com>
@thjaeckle thjaeckle added this to the 3.0.0 milestone Aug 29, 2022
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thfries - that should work just fine that way 👍
I reviewed and ensured that no credentials other than the "default" ones from the environment are added to the local browser storage.

@thjaeckle thjaeckle merged commit 754a7e3 into eclipse-ditto:master Aug 29, 2022
@thjaeckle thjaeckle added the UI Issues related to the Ditto explorer UI label Aug 29, 2022
@thfries thfries deleted the ui-fix-credential-store branch September 18, 2022 07:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to the Ditto explorer UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants