Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to provide multiple OIDC issuer urls for a single configured openid-connect "prefix" #1465

Merged

Conversation

thjaeckle
Copy link
Member

Up to now exactly one "issuer" URL could be configured.
Now, while maintaining backwards compatibility, also a list of "issuers" may be configured. If the list of "issuers" is configured, it takes priority over a configured single "issuer" URL.

… urls in the config

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…col for issuer

before determining the OIDC discovery endpoint
* added/enhanced unit tests for multiple issuer URIs

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…nnect issuer configuration

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
@thjaeckle thjaeckle added this to the 3.0.0 milestone Aug 30, 2022
Copy link
Contributor

@dguggemos dguggemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit 9b50860 into eclipse-ditto:master Sep 1, 2022
@thjaeckle thjaeckle deleted the feature/multiple-oidc-issuer-urls branch September 1, 2022 09:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants