Make it possible to retrieve disabled loggers via devops API #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
DerSchwilk
reviewed
Sep 30, 2022
| @@ -73,17 +73,24 @@ public List<LoggerConfig> getLoggerConfig(@Nonnull final Iterable<String> logger | |||
| .map(logger -> (Logger) LoggerFactory.getLogger(logger)) | |||
| .toList(); | |||
|
|
|||
| return loggerConfigsFor(loggerList); | |||
| return loggerConfigsFor(loggerList, true); | |||
There was a problem hiding this comment.
Is there a reason this is statically true?
Shouldn't this be either controlled via a parameter or set to false to resemble the prior behaviour?
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
DerSchwilk
approved these changes
Sep 30, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation filters all loggers set to "off". Add query parameter to control that behaviour.