-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept and test TextMessage with null payload #1505
Accept and test TextMessage with null payload #1505
Conversation
Signed-off-by: Tobias Månsson <tobias@zept.io>
I tried testing with a BytesMessage, but couldn't figure it out. I gave up when I got the error Reading through the code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost good to me - just 2 smaller things to adjust in the test.
The byte null
payload I could also not understand in the JMS / Qpid facade API ..
I think it is sufficient to support null
textMessage.
...c/test/java/org/eclipse/ditto/connectivity/service/messaging/amqp/AmqpConsumerActorTest.java
Show resolved
Hide resolved
...c/test/java/org/eclipse/ditto/connectivity/service/messaging/amqp/AmqpConsumerActorTest.java
Outdated
Show resolved
Hide resolved
I tried to add a BytesMessage test as well, but can't get it. Creating a empty BytesMessage makes it write-only for some reason, and setting up the body creation using byteStream is beyond me. This is my attempt:
|
@tobias-zeptio I also tried to add a test with a If you find out that you still require this also for byte messages, I suggest to create a follow-up PR. |
Cherry-picked to |
Adds the ability to handle TextMessage with null payload, from issue #1503
Signed-off-by: Tobias Månsson tobias@zept.io