End-2-end graceful shutdown support #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
… sharded actors. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…egionCreatorTest. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Reason: Ditto pubsub reacts too slowly for coordinated shutdown. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Reason: Twin operations can include acknowledgement requests. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…m pubSubMediator; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io> # Conflicts: # internal/utils/persistent-actors/src/main/java/org/eclipse/ditto/internal/utils/persistentactors/AbstractPersistenceSupervisor.java # thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/starter/actors/SearchRootActor.java # thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/updater/actors/NewEventForwarder.java # thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/updater/actors/ShardRegionFactory.java # thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/updater/actors/ThingsUpdater.java
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
fixed javadoc and typo; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…ough time to complete; removed match for DistributedPubSubMediator.SubscribeAck from GatewayProxyActor and EdgeCommandForwarderActor because no subscribe message is send via pudSubMediator; wait with stopping the AbstractHttpRequestActor until the request is completed; add test to HttpRequestActorTest; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…e and remove task when actor is shutdown; wait for requests in QueryThingsPerRequestActor; pass httpConfig to GatewayProxyActor and QueryThingsPerRequestActor; add test to QueryThingsPerRequestActorTest, Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
…ed for terminating the websocket session; extend Connect with an optional killSwitch; shutdown websocket streams in service requests done phase of CoordinatedShutdown; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
rename method; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…restarts. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…estore connection connection announcements. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…istenceActorTest. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…restarts during coordinated shutdown. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…velope for communication between the connection persistence actor and its client actors. Reason: Consistent hashable envelope is not serializable. Still to do: Make all messages wrapped in ShardedBinaryEnvelope serializable, i. e., ClientActorPropsArgs. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…ctionStatusResponse. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
… namespaces replicator in connectivity. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…cator. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…r when acknowledgements are forwarded. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…ing actor when acknowledgements are forwarded." This reverts commit 1612e74. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…down." This reverts commit 0e2259f. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Stefan Maute <stefan.maute@bosch.io> # Conflicts: # connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/rabbitmq/RabbitMQConsumerActor.java # connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/BaseClientActorTest.java # connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/httppush/HttpPushClientActorTest.java # edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/ThingsAggregatorProxyActor.java # edge/service/src/test/java/org/eclipse/ditto/edge/service/dispatching/ThingsAggregatorProxyActorTest.java # policies/service/src/test/java/org/eclipse/ditto/policies/service/persistence/actors/PolicyPersistenceOperationsActorIT.java # things/service/pom.xml # things/service/src/main/java/org/eclipse/ditto/things/service/persistence/actors/ThingSupervisorActor.java # thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/starter/actors/SearchActor.java
…test; Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add support for a better end-2-end graceful shutdown behaviour.
We have implemented some mechanisms to handle inflight requests to wait for the responses.