Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection client rebalancing fix #1549

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Connection client rebalancing fix #1549

merged 3 commits into from
Dec 12, 2022

Conversation

yufei-cai
Copy link
Contributor

@yufei-cai yufei-cai commented Dec 11, 2022 •
edited
Loading

  • Ensure that client supervisors do not get stuck if restart message is lost.
  • Increase rebalancing relative limit to coincide with absolute limit when all shards are active.
  • Fix incorrect metric reporting in client actor.

@yufei-cai
ClientSupervisor: Retrieve connection status on startup to deal with …
fdd4a61 
…shard rebalancing.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Fix metrics "connection_client" and "connecting_client" underreportin…
99639bc 
…g due to multiple client actors of a connection starting on the same instance.

Tagging the metrics by the client actor number is not possible
without significant change because the client actor props factory
does not know about client actor numbers.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Increase relative rebalance limit to coincide with absolute limit whe…
0f8c3e9 
…n all shards are active.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@thjaeckle thjaeckle added this to the 3.1.0 milestone Dec 12, 2022
@thjaeckle thjaeckle changed the title Bugfix/client rebalancing Connection client rebalancing fix Dec 12, 2022
thjaeckle
thjaeckle approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @yufei-cai 👍

@thjaeckle thjaeckle merged commit ee0b290 into eclipse-ditto:master Dec 12, 2022
@thjaeckle thjaeckle deleted the bugfix/client-rebalancing branch December 12, 2022 08:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yufei-cai @thjaeckle