Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hono connection address suffix added - hono tenant id #1579

Conversation

abalarev
Copy link
Contributor

Resolves #1574
Address resolving for hono connections is fixed to include a hono-tenant suffix.
Assuming there would be no more than 1 connection between ditto and hono, the connectionId is used for this suffix.
Therefore the connectionId must be set during creation to be the same as hono-tenant-id

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.com>
@thjaeckle thjaeckle added this to the 3.2.0 milestone Feb 14, 2023
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation needs additional escaping - apart from that: LGTM :)

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.com>
@thjaeckle
Copy link
Member

LGTM, thx @abalarev for addressing this so quickly 👍

@thjaeckle thjaeckle merged commit ac5b5ef into eclipse-ditto:master Feb 14, 2023
@thjaeckle thjaeckle deleted the bugfix/hono_connection_address_resolving branch February 14, 2023 18:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Hono connection type configuration misses configuring the Hono tenant
3 participants