Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of thing's policy is atomic with creation the of thing itself #1581

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Creation of thing's policy is atomic with creation the of thing itself #1581

merged 2 commits into from
Mar 7, 2023

Conversation

alstanchev
Copy link
Contributor

This PR adds atomic behaviour to the creation of thing and its policy.
In the rare case of failing to create a thing, its policy will be rolled back (deleted) in order to not fail create retry.

@alstanchev
Copy link
Contributor Author

@thjaeckle can you take a look when you can please.

Create of thing's policy is atomic with creation the of thing itself
77b1c03 
Signed-off-by: Stanchev Aleksandar <aleksandar.stanchev@bosch.io>

Signed-off-by: Stanchev Aleksandar <aleksandar.stanchev@bosch.io>
@thjaeckle
Copy link
Member

thjaeckle commented Feb 22, 2023 •
edited
Loading

@alstanchev I will take a look soon.
Do you work on a unit test? That can probably only be tested with mocking and producing the "thing creation failure".

thjaeckle
thjaeckle requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a first round of review comments.

.../src/main/java/org/eclipse/ditto/things/service/persistence/actors/ThingSupervisorActor.java Outdated Show resolved Hide resolved
.../src/main/java/org/eclipse/ditto/things/service/persistence/actors/ThingSupervisorActor.java Show resolved Hide resolved
Added unit tests and fixed things pointed out in the code review.
594ac98 
Signed-off-by: Stanchev Aleksandar <aleksandar.stanchev@bosch.io>
@alstanchev alstanchev marked this pull request as ready for review March 7, 2023 11:45
@thjaeckle thjaeckle added this to the 3.2.0 milestone Mar 7, 2023