Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - removed old dropdown for searchfilters #1584

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

thfries
Copy link
Contributor

@thfries thfries commented Feb 23, 2023

Hi @thjaeckle,

While I was writing my last comment, I decided to:

  • add the examples to the autocomplete search instead
  • extend the search for the group, so you can search for "all examples" or "all fields"
  • remove the old dropdown button, because it is now fully covered by the autocomplete search

Sorry, you were far faster than me on the other PR - so I created this new one

Regarding documentation: https://bootstraptour.com looks promising and very easy.

Signed-off-by: thfries <thomas.fries0@gmail.com>
@thjaeckle thjaeckle added the UI Issues related to the Ditto explorer UI label Feb 24, 2023
@thjaeckle thjaeckle added this to the 3.2.0 milestone Feb 24, 2023
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @thfries

@thjaeckle thjaeckle merged commit 750b255 into eclipse-ditto:master Feb 28, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to the Ditto explorer UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants