-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1592] provide "Bearer" authentication for devops resources controlled via UI #1594
Conversation
…ed via UI * added radiobutton groups so that "Authorize" modal clearly shows/states which authentication to use where * reduced to a single "Authorize" button in modal * simplified environment a bit Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
@thfries could you please take a look and check if this is also in your opinion good? :) Right after creating the PR I thought that the "Authorize" modal should mabye group by main / devops credentials and not by the authentication type.
What do you think? |
… devops" auth Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
I would plan the Ditto release 3.2.0 for tomorrow. |
The second approach is better. In the first case, the radio buttons do not fit, because you can work with both users in parallel (it is not either / or, you can enter both). The separation of DevOps API and "Main" API is a bit confusing. There are two variants to retrieve the connections. The DevOps user is currently only needed for the "old" Ditto 2 way to retrieve connections. Do you think we should remove the Ditto 2 support for connections? |
Hm, actually no. There are 2 variants to retrieve connections, yes. I think the proposed PR does correctly reflect the current possibilities. Also no need to drop Ditto 2 support. |
Hi @thjaeckle, Thanks! |
Thanks @thfries . Ah, yes. For Bosch IoT things the end user can have access to the connections. |
Resolves: #1592
Screenshot of modal: