Fixed filtering desired properties signals. #1599 #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vit Holasek <xvh@seznam.cz>
|
I've did wrong by mixing my test with parametrized tests. Will fix it. |
Signed-off-by: Vit Holasek <xvh@seznam.cz>
thjaeckle
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Thanks so much @kyberpunk
I reviewed and your changes look great 👍
I didn't want to change a code too much but maybe would worth to move the conversion function to ThingEvent interface an use polymorphism; so no one will forget to implement it anymore in case of new events.
Indeed, that would have been and would still be way more cleaner to do it that way.
Noted for the next model changes ;)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing a bug which caused that signal filtering did not work for desired properties changes. There was missing implementation of mapping to Thing model for such events. More details described in #1599.
I've added few unit tests covering new code and the bug itself. Also tested it manually with my K8s deployment with Kafka and it works as expected now.
I didn't want to change a code too much but maybe would worth to move the conversion function to ThingEvent interface an use polymorphism; so no one will forget to implement it anymore in case of new events.
fixes #1599