#1524 added "if-equal" header to define whether to "skip" and update of an equal value #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thjaeckle
force-pushed
the
feature/if-equal-condition
branch
from
da0c7f2
to
f784137
Compare
…of an equal value * default is "update" (which is the current behavior), always overwriting the value, even if it is equal to the one before * return a "*PreconditionNotModifiedException" (HTTP 304) when "skip" is provided and value is equal * work on logic is still in progress Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
…al" header Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle
force-pushed
the
feature/if-equal-condition
branch
from
f784137
to
65baf43
Compare
* OpenAPI * protocol * httpapi-concepts.md Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
|
@alstanchev @kalinkostashki I would appreciate a review on this - turned out to be not too complicated to do :) |
There was a problem hiding this comment.
@thjaeckle IfEqualsOption is maybe a bit of strange name for a DittoHeader ?
Shouldn't it be IfEquals only ? Or maybe IfEqualsHeader?
I don't have any hard feelings about IfEqualsOption -> just find it maybe a bit weird :)
Yes, I agree - will change enum name to |
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
documentation/src/main/resources/pages/ditto/httpapi-concepts.md
Outdated
Show resolved
Hide resolved
documentation/src/main/resources/pages/ditto/httpapi-concepts.md
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/ditto/internal/utils/headers/conditional/ConditionalHeadersValidator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1524
Open: