Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1619 adjusted monitor to use in OutboundMappingProcessorActor #1620

Merged
merged 1 commit into from
Apr 26, 2023
Merged

#1619 adjusted monitor to use in OutboundMappingProcessorActor #1620

merged 1 commit into from
Apr 26, 2023

Conversation

thjaeckle
Copy link
Member

  • to not use responseDispatchedMonitor, but getMonitorsForOutboundSignal() with using responseMappedMonitor instead for responses

Fixes: #1619

@thjaeckle
#1619 adjusted monitor to use in OutboundMappingProcessorActor#messag…
b4060fe 
…eDiscarded

* to not use `responseDispatchedMonitor`, but getMonitorsForOutboundSignal() with using `responseMappedMonitor` instead for responses

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added the bug label Apr 18, 2023
@thjaeckle thjaeckle added this to the 3.3.0 milestone Apr 18, 2023
@thjaeckle
Copy link
Member Author

@alstanchev could you take a look as reviewer?
Is only a small fix, fixing the category of outbound mapped messages in case they are dropped - which can happen for both responses, but also "normal" outbound messages.

alstanchev
alstanchev approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@thjaeckle thjaeckle merged commit 20f2316 into master Apr 26, 2023
@thjaeckle thjaeckle deleted the bugfix/1619-metrics-outbound-category branch April 26, 2023 06:08
@thjaeckle thjaeckle self-assigned this May 23, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alstanchev alstanchev alstanchev approved these changes

Assignees

@thjaeckle thjaeckle

Labels
bug
Projects
Ditto Planning
Status: Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Connection metrics for "target only" connections can be reported+logged wrongly for message dropping
2 participants
@thjaeckle @alstanchev