Support for ingress controller

[vbricentic]

Support for ingress controller
Creation of ingress-nginx namespace

[thjaeckle]

Thanks @vbricentic for this contribution.
Could you please sign your commit with the e-mail-address registered to your Eclipse account (and where you have signed the ECA)?
See also CONTRIBUTING.md

[vbricentic]

Thanks for the suggestion @thjaeckle . I have just signed the commit and eclipsefdn/eca. Is there a way to re-trigger the check or I should maybe recreate PR?

[thjaeckle]

Thanks for the suggestion @thjaeckle . I have just signed the commit and eclipsefdn/eca. Is there a way to re-trigger the check or I should maybe recreate PR?

It seems something is still off .. see the Eclipse ECA tool:

Did you configure your git email-address correctly to the one used in your eclipse account?

In addition, other checks fail as well:

• linting of the chart (the chart version needs to be increased - see the "Details")
• license headers are missing from files (see the "Details")

[vbricentic]

It should be better now, but not sure if everything is now solved. @thjaeckle could you please re-trigger check again.

[brvbosch]

Account issue finally resolved.

@thjaeckle I'm little bit confused with chart versioning. Lint and test Helm chart requires to change. In code it says it's effectively set by release-job. Version of helm currently matches application version, so I tried with 3.3.0.1 but the format was rejected. I set now to 3.3.1 but might be misleading.

[thjaeckle]

@vbricentic The chart version is still invalid:

Error: validation: chart.metadata.version "3.3.0.1" is invalid

Version of helm currently matches application version, so I tried with 3.3.0.1 but the format was rejected. I set now to 3.3.1 but might be misleading.

Yes, unfortunately we cannot always keep the versions in sync.
The Helm chart version will sometimes be ahead of the application version.

It is ok to change to 3.3.1

[brvbosch]

@thjaeckle in that case it should be now fine, I set it to 3.3.2 to not conflict with #1667
So it would just need to merge after that

[thjaeckle]

Hey @vbricentic
I did a first round of reviews and added some comments.

Please move the ingress "controller" specific config to a separate YAML "object" - and make it configurable that the Ingress controller is deployed or not (if Ingress is enabled).

[brvbosch]

@thjaeckle version bumped again

[thjaeckle]

@vbricentic awesome, thanks for the adjustments and for the contribution. 👍
I will add it to the "3.3.1" milestone and will release it with a Helm chart version containing the Ditto 3.3.1 bugfix release.