Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gha): Avoid running cron on forks #1677

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(gha): Avoid running cron on forks #1677

merged 1 commit into from
Jul 5, 2023

Conversation

Altair-Bueno
Copy link
Contributor

@Altair-Bueno Altair-Bueno commented Jul 5, 2023

The cron job of Ditto is triggered each day on forks, which leads to annoying failed jobs (see https://github.com/ertis-research/ditto/actions/runs/5459864259/jobs/9936273159, for example). Solution is based on the following sources:

PS: This change also triggered maven tests, which failed. See https://github.com/ertis-research/ditto/actions/runs/5461992872/jobs/9940730952. It may be wise to add .github to the list of ignored paths on maven.yml, and identify the reason why it failed.

Signed-off-by: Altair-Bueno <altair.bueno@uma.es>
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Altair-Bueno
Very valid PR .. did not think about that.

You could probably also deactivate GH Actions for your fork completely - but I agree that the PR makes sense.

@thjaeckle thjaeckle merged commit 8273bec into eclipse-ditto:master Jul 5, 2023
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants