-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocumentDB support #1693
Merged
alstanchev
merged 7 commits into
eclipse-ditto:master
from
bosch-io:feature/enable-documentDB
Jul 18, 2023
Merged
DocumentDB support #1693
alstanchev
merged 7 commits into
eclipse-ditto:master
from
bosch-io:feature/enable-documentDB
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed cursor.collation()\ - removed $$CURRENT and $setDifference Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.io>
…apshots * conditionally removing "DELETED" snapshots using "$redact" instead of using "$$CURRENT" and "$setDifference" Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
* got rid of "collation" -> "numericOrdering(true)" using another step in the aggregation * append "$$ROOT" in snapshot listing to include all selected fields * adjusted some "batchSizes" in unit tests Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
* based on that changed how the priority sorting is done * apply a workaround to get priority sorting also for documentDB mode * use "collation" and "numericOrdering=true" (as it was done before) for non-DocumentDB compatibility mode * run MongoReadJournalIT parameterized with and without documentDB compatibility mode Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
…n "documentDbCompatibilityMode" Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
* documented limitations and workarounds for those limitations Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
alstanchev
force-pushed
the
feature/enable-documentDB
branch
2 times, most recently
from
July 17, 2023 14:49
d68b650
to
7b452a9
Compare
thjaeckle
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Amazon DocumentDB with some limitations explained in the documentation.