Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentDB support #1693

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Conversation

alstanchev
Copy link
Contributor

This PR adds support for Amazon DocumentDB with some limitations explained in the documentation.

Kalin Kostashki and others added 7 commits January 18, 2023 10:19
 - removed cursor.collation()\
 - removed $$CURRENT and $setDifference

Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.io>
…apshots

* conditionally removing "DELETED" snapshots using "$redact" instead of using "$$CURRENT" and "$setDifference"

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
* got rid of "collation" -> "numericOrdering(true)" using another step in the aggregation
* append "$$ROOT" in snapshot listing to include all selected fields
* adjusted some "batchSizes" in unit tests

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
* based on that changed how the priority sorting is done
* apply a workaround to get priority sorting also for documentDB mode
* use "collation" and "numericOrdering=true" (as it was done before) for non-DocumentDB compatibility mode
* run MongoReadJournalIT parameterized with and without documentDB compatibility mode

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
…n "documentDbCompatibilityMode"

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
* documented limitations and workarounds for those limitations

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@beyonnex.io>
@alstanchev alstanchev force-pushed the feature/enable-documentDB branch 2 times, most recently from d68b650 to 7b452a9 Compare July 17, 2023 14:49
@thjaeckle thjaeckle added this to the 3.4.0 milestone Jul 17, 2023
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alstanchev alstanchev merged commit 01ad7d9 into eclipse-ditto:master Jul 18, 2023
2 checks passed
@alstanchev alstanchev deleted the feature/enable-documentDB branch July 18, 2023 06:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants