Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix using "/cloudevents" endpoint for other entities than things #1724

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

thjaeckle
Copy link
Member

  • e.g. policy commands could not be created with the "POST /cloudevents" endpoint as "response-required" was always set to false in combination with setting a "requested ACK" (which is only available for thing commands)

* e.g. policy commands could not be created with the "POST /cloudevents" endpoint as "response-required" was always set to `false` in combination with setting a "requested ACK" (which is only available for thing commands)

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added the bug label Aug 23, 2023
@thjaeckle thjaeckle added this to the 3.3.6 milestone Aug 23, 2023
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki it would be great if you could have a short look at this bugfix

Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thjaeckle thjaeckle merged commit 480e0c9 into master Aug 23, 2023
3 checks passed
@thjaeckle thjaeckle deleted the bugfix/cloudevents-policy-commands branch August 23, 2023 10:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants