Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spread ditto services equally among cluster nodes #1734

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Spread ditto services equally among cluster nodes #1734

merged 3 commits into from
Sep 7, 2023

Conversation

vladica
Copy link
Contributor

@vladica vladica commented Sep 6, 2023

This PR delivers two improvements:

  1. Add Pod Topology Spread Constraints to spread ditto services equally among cluster nodes. Each deployment has the ability to set constraints independently.
  2. Extract nginx-ingress configuration hard-coded values to the values.yaml file:
    • replicaCount
    • updateStrategy
    • minReadySeconds
    • revisionHistoryLimit
    • resources

@vladica
add topology spread constraints so ditto services spread equally amon…
93a94bb 
…g cluster nodes

Signed-off-by: Vladica Obojevic <obojevic@gmail.com>
@vladica
extract to values.yaml file hard-coded nginx-ingress configuration va…
c81c2b7 
…lues

Signed-off-by: Vladica Obojevic <obojevic@gmail.com>
@vladica
Bump Chart version
f34a465 
Signed-off-by: Vladica Obojevic <obojevic@gmail.com>
thjaeckle
thjaeckle approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot @vladica for this contribution.

I also had this on my "todo / to look into" list - this is super useful for maintaining high availability in case of a zone crashing when e.g. 3 zones are available. 👍
So: Much appreciated.

@thjaeckle thjaeckle merged commit eceab7a into eclipse-ditto:master Sep 7, 2023
9 checks passed
@thjaeckle thjaeckle added this to the 3.3.7 milestone Sep 8, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees

@vladica vladica

Labels
Helm chart
Projects
Ditto Planning
Status: Done
Milestone
3.3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@vladica @thjaeckle