#1703 fixed wrongly emptied out search index on policy retrieval error due to internal timeouts #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alstanchev / @kalinkostashki this is a little fix I would add to 3.4.0 This is quite nasty if many things use a single policy and this is changed .. due to load and internal "ask timeouts" it may lead to that a lot of search index entries are basically removed and the things are no longer findable. For such internal timeouts I added that the entry is not removed from the search index - which will lead to the "Background sync" mechanism of the search to ensure eventual consistency, applying the potentially changed policy later. |
…r due to internal timeouts Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle
force-pushed
the
bugfix/fix-emptied-out-search-index-on-policy-failed-fetch
branch
from
9578f85
to
abda3b4
Compare
thjaeckle
deleted the
bugfix/fix-emptied-out-search-index-on-policy-failed-fetch
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1703