Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix that ThingFieldSelector did not allow specific paths of "_metadata" #1782

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix that ThingFieldSelector did not allow specific paths of "_metadata" #1782

merged 1 commit into from
Nov 1, 2023

Conversation

thjaeckle
Copy link
Member

  • it only allowed to select top-level "_metadata" - which does not make sense to limit, as even selecting only specific _metadata is already supported
  • also add missing support for featureId wildcard when selecting e.g. "_metadata/features/*/properties"

@thjaeckle
fix that ThingFieldSelector did not allow specific paths of "_metadata"
2f52170 
* it only allowed to select top-level "_metadata" - which does not make sense to limit, as even selecting only specific _metadata is already supported
* also add missing support for featureId wildcard when selecting e.g. "_metadata/features/*/properties"

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added the bug label Oct 26, 2023
@thjaeckle thjaeckle added this to the 3.4.1 milestone Oct 26, 2023
@thjaeckle
Copy link
Member Author

Could you please have a look, @alstanchev @kalinkostashki

@thjaeckle thjaeckle self-assigned this Oct 31, 2023
alstanchev
alstanchev approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alstanchev alstanchev merged commit e6f1636 into master Nov 1, 2023
3 checks passed
@alstanchev alstanchev deleted the bugfix/fix-metadata-fieldselector-restrictiveness branch November 1, 2023 14:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alstanchev alstanchev alstanchev approved these changes

Assignees

@thjaeckle thjaeckle

Labels
bug
Projects
Ditto Planning
Status: Done
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@thjaeckle @alstanchev