fix that non-successful message responses were not displayed in ACE editor #1810
Conversation
thjaeckle
commented
Nov 21, 2023
thjaeckle
commented
- only successful responses were displayed
- however, messages might e.g. be answered with a 400 (bad request) and useful information as response
…ditor * only successful responses were displayed * however, messages might e.g. be answered with a 400 (bad request) and useful information as response
|
@thfries I noticed that only successful message responses were displayed in the "response" ace editor Could you please have a short look on the improvement/fix? I also thought that displaying the status code might also be helpful, but had no good idea to add it to the current layout. |
|
Hi @thjaeckle, I am missing the usual error toast now that is popping up in case of errors but I did not find a way to show it in addition to filling the response editor. Other than that LGTM👍 I started working on having a separate field for the status similar like on the piggypack commands. But there is no easy way without some changes on the layout. Can be added later. |
|
Thanks, will look into the toasts for other errors .. |
* display error toast also for message responses with "failed" response code * but still display the response as well in the messages response ace editor * still show JSON errors which are not formatted as "ditto error" (containing at least status and message) Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
|
@thfries I now additionally show the "error toast" and improved that, displaying also errors which are not in "Ditto error format". |
|
Nice! I like it. Thank you! |
