#1854 enhance time:now* placeholders to calculate plus and minus from now #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now * and to optionally truncate to a unit (rounding down) Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
alstanchev
reviewed
Jan 4, 2024
| private static final String TRUNCATE_START; | ||
| private static final String TRUNCATE_END = "]"; | ||
|
|
||
| static { |
There was a problem hiding this comment.
Is there a need for this static block?
Is it null sometimes when the static methods are called?
There was a problem hiding this comment.
Yeah, that was kinda strange. I could not declare "[" directly to a static constant.
IbtelliJ was complaining.
But when I moved the assignment into the static block, it worked..
Could also be an IDE bug.. 😕
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1854
Open: