#1878 update Ditto to run with Java 21 JDK #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alstanchev @kalinkostashki I would appreciate a review I mainly deleted the |
* models stay at JDK 8; services and internal APIs are built against 21 * remove mutability-detector dependency and tests, as this is no longer maintained and not working with Java 21 * update equalsverifier and bytebuddy versions to get equals checking unit tests running
thjaeckle
force-pushed
the
update-java-21
branch
from
3d05865
to
d948b46
Compare
thjaeckle
force-pushed
the
update-java-21
branch
from
d948b46
to
c6aa053
Compare
|
@alstanchev could you formally approve this PR? |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1878