Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete duplicate nginx body style #2001

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

neottil
Copy link
Contributor

@neottil neottil commented Aug 20, 2024

delete duplicate nginx body style in all deployments nginx configurations

@neottil
Copy link
Contributor Author

neottil commented Aug 20, 2024

@thjaeckle how can I fix the lint-chart check? I see in the code that the 2"hart version is effectively set by release-job".

@thjaeckle
Copy link
Member

@neottil thanks for the PR - you just need to bump the version to next patch version - the linting enforces that the version is updated (and checks against master branch).

@neottil
Copy link
Contributor Author

neottil commented Aug 26, 2024

@thjaeckle now it's ok.
Thanks

Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👍

@thjaeckle thjaeckle added this to the 3.6.0 milestone Aug 26, 2024
@thjaeckle thjaeckle merged commit aff14db into eclipse-ditto:master Aug 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants