Fix authorization request handling issue #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where the client sends an immediate authorization response upon receiving the authorization request, which might get ignored, causing the client to be stuck waiting for the authorization response. From now on, the DownloadManager and UpdateManager actors will first wait for the authorization response and then broadcast the event/state regarding the authorization to the client. Signed-off-by: Saeed Rezaee <saeed.rezaee@kynetics.it>
SaeedRe
force-pushed
the
UF-870_fix_authorization_response_immediate_response
branch
from
0d79c6a
to
84759d1
Compare
Signed-off-by: Saeed Rezaee <saeed.rezaee@kynetics.it>
Signed-off-by: Saeed Rezaee <saeed.rezaee@kynetics.it>
andrea-zoleo
approved these changes
May 21, 2024
|
Mac OS test is failing due to docker setup issue, but tests are succeeding locally. |
diegorondini
deleted the
UF-870_fix_authorization_response_immediate_response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where the client sends an immediate
authorization response upon receiving the authorization request, which
might get ignored, causing the client to be stuck waiting for the
authorization response.
From now on, the DownloadManager and UpdateManager actors will first
wait for the authorization response and then broadcast the event/state
regarding the authorization to the client.