Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patterns] Suggest identifier completion for obj instanceof Dog #92

Closed
mickaelistria opened this issue Apr 19, 2022 · 3 comments · Fixed by #2011
Closed

[Patterns] Suggest identifier completion for obj instanceof Dog #92

mickaelistria opened this issue Apr 19, 2022 · 3 comments · Fixed by #2011
Assignees
@srikanth-sankaran
Milestone
MilestoneNxt

Comments

@mickaelistria
Copy link
Contributor

Similarly to how identifier completion (usually derived from type) is available when declaring a variable, it would be nice to get similar completion after the obj instanceof Dog to completion (when using recent enough Java), would suggest if (obj isntanceof Dog dog).
@ktatavarthi
Copy link
Member

Moving to jdt.core as code completion is implemented in jdt.core

@ktatavarthi ktatavarthi transferred this issue from eclipse-jdt/eclipse.jdt.ui May 20, 2022
@ktatavarthi
Copy link
Member

@vik-chand Can you please look at this bug, when you get a chance.

@srikanth-sankaran srikanth-sankaran self-assigned this Jul 2, 2023
@srikanth-sankaran srikanth-sankaran changed the title Suggest identifier completation for obj instanceof Dog Suggest identifier completion for obj instanceof Dog Feb 18, 2024
@srikanth-sankaran srikanth-sankaran changed the title Suggest identifier completion for obj instanceof Dog [Patterns] Suggest identifier completion for obj instanceof Dog Feb 18, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 18, 2024
@srikanth-sankaran
* Code completion support for instance of type pattern
a229ca3 
* Fixes eclipse-jdt#92
@srikanth-sankaran srikanth-sankaran mentioned this issue Feb 18, 2024
Merged
3 tasks
@srikanth-sankaran srikanth-sankaran added this to the 4.32 M1 milestone Feb 18, 2024
@mpalat mpalat modified the milestones: 4.32 M1, MilestoneNxt Mar 1, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Mar 5, 2024
@srikanth-sankaran
* Code completion support for instance of type pattern
9397985 
* Fixes eclipse-jdt#92
@mickaelistria
Copy link
Contributor Author

Thank you!

robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Jul 18, 2024
@srikanth-sankaran
* Code completion support for instance of type pattern
c7f1bec 
* Fixes eclipse-jdt#92
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this issue Sep 7, 2024
@srikanth-sankaran @gayanper
* Code completion support for instance of type pattern
e9d3c58 
* Fixes eclipse-jdt#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-sankaran srikanth-sankaran

Labels
None yet
Projects
None yet
Milestone
MilestoneNxt
Development

Successfully merging a pull request may close this issue.

[Patterns] Cumulative fixes for various problems srikanth-sankaran/eclipse.jdt.core
4 participants
@mickaelistria @mpalat @ktatavarthi @srikanth-sankaran