Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23] Partition support for markdown comments #1542

Closed
jarthana opened this issue Jul 25, 2024 · 2 comments · Fixed by #1549
Closed

[23] Partition support for markdown comments #1542

jarthana opened this issue Jul 25, 2024 · 2 comments · Fixed by #1549
Assignees
@jarthana
Milestone
BETA_JAVA23

Comments

@jarthana
Copy link
Member

Compiler support has now been added in jdt.core and code assist is planned via eclipse-jdt/eclipse.jdt.core#2744. My initial investigation shows that some work is needed in jdt.ui to make code completion requests to jdt.core APIs. I understand there's this notion of partition and we may need a new partition kind or treat /// same as Javadoc so that code completion requests are made and processed in the UI.
@jarthana jarthana added this to the BETA_JAVA23 milestone Jul 25, 2024
@jarthana
Copy link
Member Author

Setting the milestone to BETA_JAVA23. Also would like to emphasize that this is a blocker for all jdt.core completion in markdown comments.

jarthana added a commit that referenced this issue Jul 26, 2024
@jarthana
[23] Partition support for markdown comments #1542
c659493
@jarthana jarthana mentioned this issue Jul 26, 2024
Merged
3 tasks
jarthana added a commit that referenced this issue Aug 20, 2024
@jarthana
[23] Partition support for markdown comments #1542
fb6b69f
This was referenced Aug 20, 2024
Closed
Closed
Closed
jarthana added a commit that referenced this issue Aug 26, 2024
@jarthana
[23] Partition support for markdown comments #1542
0cc4178
jarthana added a commit that referenced this issue Aug 27, 2024
@jarthana
[23] Partition support for markdown comments #1542 (#1549)
351e805 
* Introduces a new partition type for markdown comments, which is similar to Javadoc in many ways. Primarily, the goal is to enables the editor to support formatting and editing such as completion in markdown comments.
* Markdown comment is formatted with the same style as Javadoc.
* Markdown comments can be expanded and collapsed similar to Javadoc
@jarthana jarthana self-assigned this Aug 27, 2024
@jarthana
Copy link
Member Author

This is complete, except for few minor follow-up issues, for which I will raise new issues. Closing this now.

stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.ui that referenced this issue Aug 27, 2024
@stephan-herrmann
[23] Tests for link completion inside markdown comments.
8fa728c 
After eclipse-jdt#1542 enabled
completion inside markdown comments, this change adds infrastructure and
smoketests for end-to-end testing of markdown link completion.

Also adds another forgotten test class to the suite.
@stephan-herrmann stephan-herrmann mentioned this issue Aug 27, 2024
Merged
stephan-herrmann added a commit that referenced this issue Aug 27, 2024
@stephan-herrmann
[23] Tests for link completion inside markdown comments. (#1616)
6e31e9f 
After #1542 enabled
completion inside markdown comments, this change adds infrastructure and
smoketests for end-to-end testing of markdown link completion.

Also adds another forgotten test class to the suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarthana jarthana

Labels
None yet
Projects
None yet
Milestone
BETA_JAVA23
Development

Successfully merging a pull request may close this issue.

[23] Partition support for markdown comments #1542 eclipse-jdt/eclipse.jdt.ui
1 participant
@jarthana