Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push down code related to java partition scanners, now that o.e.jface… #1011

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

robstryker
Copy link
Contributor

….text.rules have been moved to org.eclipse.text

What it does

How to test

Author checklist

….text.rules have been moved to org.eclipse.text

Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
@robstryker
Copy link
Contributor Author

@jjohnstn I noticed in #992 that you didn't like me removing the api problem filter.

The problem is, my patches continue to fail unless I remove the problem filter. For example: https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/PR-1011/2/consoleFull

15:41:25  [INFO] API Analysis finished in 19 s.
15:41:25  [INFO] 0 API ERRORS
15:41:25  [INFO] 1 API warnings
15:41:25  [WARNING] [API WARNING] File MANIFEST.MF at line 0: The API problem filter for: 'The minor version should be the same for version 1.21.0, since no new APIs have been added since version 1.20.0' is no longer used (location: /home/jenkins/agent/workspace/eclipse.jdt.ui-github_PR-1011/org.eclipse.jdt.core.manipulation/META-INF/MANIFEST.MF)

I'm sorry if I keep causing extra work by removing this filter, but the build basically keeps demanding it. :|

@jjohnstn
Copy link
Contributor

Hi @robstryker The time before I applied your patch and I got an error, but with this patch I am no longer setting the error. Probably because you added the split in MANIFEST.MF so this time it is fine to remove.

@jjohnstn
Copy link
Contributor

I did a review and I'm fine once it passes verification. I will restart the build in case it is a spurious error.

@robstryker
Copy link
Contributor Author

Thanks. I'm unable to replicate the test failure locally. Will keep my eye on it.

Copy link
Contributor

@jjohnstn jjohnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@jjohnstn jjohnstn merged commit d9752ee into eclipse-jdt:master Dec 14, 2023
9 checks passed
@jjohnstn jjohnstn self-assigned this Dec 14, 2023
@jjohnstn jjohnstn added the enhancement New feature or request label Dec 14, 2023
@jjohnstn jjohnstn added this to the 4.31 M1 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants