Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove includes of 3rd party libraries from the org.eclipse.jdt feature #107

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Aug 15, 2024

No description provided.

@merks
Copy link
Contributor Author

merks commented Aug 15, 2024

I analyzed the dependencies of the feature's 3rd party includes:

image

And verified that each one is included bundles is transitively required by one of the JDT Junit Runtimes, e.g.,

image

The only one for which that is not the case, is hamcrest, but it's transitively required by org.junit:

image

@merks merks force-pushed the pr-jdt-feature-remove-3rd-party branch from 57f5885 to f3d9867 Compare August 15, 2024 08:04
@akurtakov
Copy link
Contributor

I would rather see this one delayed for next release to reduce possible "surprises".

@merks
Copy link
Contributor Author

merks commented Aug 15, 2024

Wow, the verification build doesn't really test anything?

@akurtakov
Copy link
Contributor

For this repo yes.

@merks
Copy link
Contributor Author

merks commented Aug 15, 2024

@iloveeclipse

As requested in #106 (comment) I created a PR, but given this verification build doesn't really test much of anything and given we are post m3, it's probably not a good time to do potentially disruptive changes.

@merks
Copy link
Contributor Author

merks commented Aug 15, 2024

We can try revisit this as soon as 4.34 / 2024-12 opens for development.

@merks merks force-pushed the pr-jdt-feature-remove-3rd-party branch from f3d9867 to e210206 Compare September 11, 2024 05:44
@merks merks marked this pull request as ready for review September 11, 2024 05:44
@merks
Copy link
Contributor Author

merks commented Sep 11, 2024

FYI, this related change has been merged:

eclipse-platform/eclipse.platform.releng.aggregator#2332

@akurtakov akurtakov merged commit c37842a into eclipse-jdt:master Sep 11, 2024
3 checks passed
@merks merks deleted the pr-jdt-feature-remove-3rd-party branch September 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants