Fix #184: IngressEnricher seems to be broken #213

rohanKanojia · 2020-05-28T09:58:40Z

Ported PR fabric8io/fabric8-maven-plugin#1730

codecov · 2020-05-28T10:12:29Z

Codecov Report

Merging #213 into master will increase coverage by 0.71%.
The diff coverage is 49.23%.

@@             Coverage Diff              @@
##             master     #213      +/-   ##
============================================
+ Coverage     27.40%   28.11%   +0.71%     
- Complexity     1669     1689      +20     
============================================
  Files           353      353              
  Lines         18310    18202     -108     
  Branches       2781     2761      -20     
============================================
+ Hits           5017     5117     +100     
+ Misses        12729    12486     -243     
- Partials        564      599      +35

Impacted Files	Coverage Δ	Complexity Δ
...ipse/jkube/kit/config/resource/ResourceConfig.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...g/eclipse/jkube/kit/enricher/api/BaseEnricher.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
.../kit/enricher/api/util/KubernetesResourceUtil.java	`16.92% <0.00%> (-0.27%)`	`30.00 <0.00> (ø)`
...ube/enricher/generic/DefaultNamespaceEnricher.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...ube/enricher/generic/openshift/ExposeEnricher.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...lipse/jkube/maven/plugin/mojo/build/ApplyMojo.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...se/jkube/maven/plugin/mojo/build/ResourceMojo.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...kube/enricher/generic/openshift/RouteEnricher.java	`59.25% <51.92%> (+59.25%)`	`10.00 <7.00> (+10.00)`
...clipse/jkube/enricher/generic/IngressEnricher.java	`58.42% <60.65%> (+58.42%)`	`10.00 <8.00> (+10.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5c783...d3f6e45. Read the comment docs.

...e-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/IngressEnricher.java

...richer/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricher.java

manusa · 2020-06-03T06:12:25Z

...richer/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricher.java

+                            withHost(routeDomainPostfix.isEmpty() ? null : routeDomainPostfix).
+                            endSpec();
+
+                    // removing `expose : true` label from metadata.


What does this imply?

I think it's about removing expose=true labels added by ExposeEnricher

Yes, I see that. But what does that expose=true label > ExposeEnricher do?

I think it something fabric8 only related (hence deprecated) but I may be wrong

https://blog.fabric8.io/additional-kubernetes-controllers-from-fabric8-you-can-use-with-your-microservice-3126a2c4c132
https://github.com/jenkins-x/exposecontroller

...s-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ApplyMojo.java

kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_faq.adoc

jkube-kit/enricher/api/src/main/java/org/eclipse/jkube/kit/enricher/api/util/Constants.java

Ported PR fabric8io/fabric8-maven-plugin#1730

sonarcloud · 2020-06-04T16:42:19Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

57.1% Coverage
0.0% Duplication

The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

rohanKanojia force-pushed the pr/issue184 branch from 0435369 to 97f8e22 Compare May 28, 2020 10:15

rohanKanojia requested a review from manusa June 2, 2020 10:44