Propagate Mojo-lookup errors and create test-case for #1150 #1160
Conversation
|
That reminds me that I wanted to create a little guide about 'How to contribute a test-case'. |
|
From the tests it looks like we would have seen that earlier if the mojo execution errors would not have been swallowed. |
| @@ -331,6 +332,7 @@ private static void executeMojo(MavenSession session, MojoExecution execution, I | |||
| lookup.lookup(BuildPluginManager.class).executeMojo(session, execution); | |||
| } catch(Exception ex) { | |||
| session.getResult().addException(ex); | |||
| throw new CoreException(Status.error("Failed to execute mojo", ex)); | |||
There was a problem hiding this comment.
Thats not the place to handle this, the caller has to check the result and act accordingly (e.g. m2e has helper classes to create error markers from results).
There was a problem hiding this comment.
I checked this more deeply in m2e an it seems this actually is already handled at a higher level, even though in some places we return the result. It seems strange here to have both (throwing an exception and adding it to the result). So I think simply throwing an exception would be enough
I don't think so. This is most probably caused by m2e not using the right context fro creation of the |
|
merged as part of |
This adds a test case to reproduce #1150. It succeeds if you rename the
.mvnfolder of the project used in the test.The reason for the failure is that in
MavenExecutionContext.executeMojo()the looked upBuildPluginManagerfailed to look-up the the mojo for themaven-resources-plugin:resourcesgoal.The cause is probably in the
IComponentLookupcreated for that multi-module project, since without a.mvn-folder a un-rooted look-up is created that succeeds. My first guess is that some settings are missing, but on my first look I didn't find anything.