Support sub bundles build #940
Conversation
Currently PDE only builds the "main bundle" but not sub-bundles, this adds support for building these as well.
laeubi
force-pushed
the
sub_bundle_build
branch
from
49e50b1
to
8a6b9da
Compare
| @@ -2,7 +2,7 @@ Manifest-Version: 1.0 | |||
| Bundle-ManifestVersion: 2 | |||
| Bundle-Name: %name | |||
| Bundle-SymbolicName: org.eclipse.pde.core; singleton:=true | |||
| Bundle-Version: 3.17.300.qualifier | |||
| Bundle-Version: 3.17.400.qualifier | |||
There was a problem hiding this comment.
Why have you changed it? This causes now API error because it was already changes for the 4.31 release.
Please consider quickly revert this before next IBuild kicks in.
There was a problem hiding this comment.
Why have you changed it? This causes now API error because it was already changes for the 4.31 release.
Why it not failed this PR?
There was a problem hiding this comment.
I guess this is yet another API tools mystery.
There was a problem hiding this comment.
There was another issue with API error not being reported, see eclipse-jdt/eclipse.jdt.ui#914 .
Note that eclipse-jdt/eclipse.jdt.ui#914 is reported in SDK build and in the IDE.
So it could be some new tycho build issue.
There was a problem hiding this comment.
There was another issue with API error not being reported
The green build reports it as a warning
[2023-11-29T07:02:13.259Z] [WARNING] [API WARNING] File MANIFEST.MF at line 5: The service version is increased unnecessarily since either the major or minor or service version is already increased (location: /home/jenkins/agent/workspace/eclipse.pde_PR-940/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF)
So it could be some new tycho build issue.
API tools is provided by PDE not Tycho, Tycho just provides a wrapper around it, so either it is configured differently WARNING vs ERROR or the configuration is not picket up by Tycho @vik-chand might better know if/how/where this is to be configured.
There was a problem hiding this comment.
Tycho just provides a wrapper around it
That is what I've meant with SDK/IDE build showing error.
I have no idea if it is the wrapper or the tycho config or whatever else.
API tooling in the IDE works.
There was a problem hiding this comment.
I have now debugged the case and the problem is that ApiProblem.getSeverity() always return the default as it passes null as a project... Why it works in IDE/SDK ist because here Error Markers are used and when ApiTools converts ApiProblem > Error Marker it does IGNORE ApiProblem.getSeverity() and instead computes the value again but this time using current build project... will replicate this behaviour with Tycho as well ...
There was a problem hiding this comment.
Actually ApiProblem.getSeverity() is only used in two places:
- ApiProblem.toString (what will print wrong value then or at least ignores the project settings)
- In a
org.eclipse.pde.api.tools.problems.tests.ApiProblemTests.testGetSeverity()
so actually I think that method can completely be deleted to prevent further confusion...
Currently PDE only builds the "main bundle" but not sub-bundles, this adds support for building these as well.