-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 96 - fixes to setup an Eclipse IDE for contribution without Eclipse error markers #136
base: master
Are you sure you want to change the base?
Conversation
… files - removed all Eclipse projects metadata files: - .settings/, .classpath, .project - these files will be created and maintained by Eclipse m2e Maven import/update - .gitignore: - added .settings/, .classpath, .project Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
- pdt/plugins/org.eclipse.php.ui/.gitignore: - added IPHPHelpContextIds.java Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
- pom.xml: - added M2E lifecycle mappings for plugin goals unknown to Eclipse Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
…groupId and version - several pom.xml: - removed redundant definition of the artifacts groupId and version Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
In theory those files are from era without Maven Tycho. You decide to remove Same for Last problem, from my point of view is deletion of |
To be honest I did not have a detailed look into the one or other .settings file - same for .project. |
…metadata files" This reverts commit f6c50d4. Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
… be managed by Eclipse m2e - .gitignore: - added .classpath Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
…builder and Maven nature added Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
@zulus With the three subsequent commits I did revert the commit of the .project and .settings removal. I only did remove the .classpath files and added those to .gitignore. The .project files did have been committed with the Maven nature and Maven build spec added - this is performed automatically by m2e during Maven import. Regarding the .settings adoptions made by my Eclipse runtime I found a lot of settings due to maybe newer Eclipse features than the one the current settings have been committed with. |
After merging this pull request the procedure for setting up an Eclipse environment for contribution is as follows: