Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct syntax for require in refactoring help file. #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agmckee
Copy link
Contributor

@agmckee agmckee commented Sep 3, 2022

Fixes #139.

As noted in #139 the current documentation is wrong require(RenFile1.php); will error as it will be evaluated as two undefined constants (RenFile1 and php) and the concatenation operator (.) which will cause a warning about each undefined constant and it will then try to concatenate these undefined constants. It will then try to require the file RenFile1php which will raise a fatal error (because using require, rather than include). Definitely more than unhelpful if the IDE help files don't use correct syntax for the examples!

require in PHP is a language level feature not a function, but I didn't update the syntax to the more usual require "file.php" because the function-like syntax is also acceptable.

@agmckee
Copy link
Contributor Author

agmckee commented Sep 3, 2022

The Tycho build check always seems to error, what's the point of such checks if they're this unreliable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem in file getting_started/basic_tutorial/working_with_refactoring.html
1 participant