Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 516335 - Rewrite CA with ImportRewrite and support new features #44

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zulus
Copy link
Member

@zulus zulus commented May 12, 2020

Continue Alex Xu original work on GitHub.

@zulus zulus changed the title [WIP] Bug 516335 - Rewrite CA with ImportRewrite and support new features Bug 516335 - Rewrite CA with ImportRewrite and support new features May 12, 2020
@zulus zulus added this to the 7.2 milestone May 18, 2020
@zulus
Copy link
Member Author

zulus commented May 19, 2020

Patch looks promising now, I fixed override on for methods imported via trait and code assist in class body on last position. 52 test failures.

CA support method override, method stub etc...

Broken tests are mostly related to CA for trait methods. 52 tests now

@zulus zulus force-pushed the bug_516335 branch 3 times, most recently from a47630e to e6dec96 Compare May 20, 2020 16:35
* Getter/Setter suggestions
* Improved method overrides
* Magic method stubs
* Alternate method calls (defaults)

Signed-off-by: Alex Xu <ibazzi@qq.com>
Also-by: Dawid Pakuła <zulus@w3des.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants