Are there bundles included by features that are unused? #1361
Comments
|
Sounds good to me.
Yes they are used by PDE: |
|
Is there something planned here? |
|
I think these can be removed and the appear to be present purely because features include them.
So we could plan and try to remove them, though one is always concerned that something might stop working for unexpected reasons... Looking at a one of these, it does appear that the exported packages that are potentially used are provided by alternatives, e.g., mortbay:
So my sense is that this is accumulated baggage and that we might be well-served to clean it up... What do you think? |
|
Sounds the right thing to do to me unless they are newer versions. Testing help system would be needed. |
|
Looking closely at all the places to remove includes from features I found this feature:
It appears to be an orphan that is not needed and not used; if I cleaned it up, it would be an empty feature! Perhaps I start the cleanup process by removing this feature... |
This appears not to be mentioned/used anywhere. Further it appears that the last time it was in any p2 repository was for indigo. eclipse-platform/eclipse.platform.releng.aggregator#1361
|
Doing some "runtime testing" I can verify that these are missing:
The last one in inconclusive because it is present, but I see this:
and I see that the mortbay bundle exports the necessary packages with versions that match
|
This appears not to be mentioned/used anywhere. Further it appears that the last time it was in any p2 repository was for indigo. eclipse-platform/eclipse.platform.releng.aggregator#1361
|
Using some targlet magic I excluded the three bundles from the target platform and jasper bundle still compiles and the help still works:
|
These bundles are included by features but are not actually needed at runtime. eclipse-platform/eclipse.platform.releng.aggregator#1361
These bundles are included by features but are not actually needed at runtime. eclipse-platform/eclipse.platform.releng.aggregator#1361
These bundles are included by the org.eclipse.help feature but are not actually needed at runtime. Also remove the include of com.sun.el.javax.el from the org.eclipse.help feature to eliminate its last 3rd party bundle include; the org.eclipse.equinox.jsp.jasper bundle's package requirement of the com.sun.el package is sufficient. Remove these also from the places where the doc.isv mentions then. And finally, remove them from the target platform itself. eclipse-platform#1361
These bundles are included by the org.eclipse.help feature but are not actually needed at runtime. Also remove the include of com.sun.el.javax.el from the org.eclipse.help feature to eliminate its last 3rd party bundle include; the org.eclipse.equinox.jsp.jasper bundle's package requirement of the com.sun.el package is sufficient. Remove these also from the places where the doc.isv mentions then. And finally, remove them from the target platform itself. #1361
|
All the removals all complete. We'll need to keep an eye on the next I-Build for regressions. |
Some smaller products have narrower dependencies that are satisfied by these, even if the SDK itself doesn't need/use them. eclipse-platform#1361
Some smaller products have narrower dependencies that are satisfied by these, even if the SDK itself doesn't need/use them. #1361
The javadoc build seems to need them. eclipse-platform#1361
The javadoc build seems to need them. #1361
I did an analysis of the Platform repository, excluding all features, to see if there are IUs that are not strictly required by anything, i.e., ones with no children in the view:
I suspect these can be removed...
There are also these, but I think these are not present for use at runtime but rather are needed at development time, so that's okay:
The text was updated successfully, but these errors were encountered: