Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ActivitySupport filtering for DynamicContributionContributionItem #2217

Open
raghucssit opened this issue Aug 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@raghucssit
Copy link
Contributor

org.eclipse.e4.ui.workbench.renderers.swt.DynamicContributionContributionItem is a Contribution Item contributed by E4 Application model.
This does not support Activity Support filtering like org.eclipse.ui.internal.PluginActionContributionItem.

An example Window-->Spies Menu Item is visible even if we disable Plug-in Development Activity in Window-->Preferences-->General-->Capabilities-->Development-->Plug-in Development.
Note that, Activity Support workin fine for other E3 components like views, wizards etc.
spies-menu-item

I tried to implement this support at org.eclipse.e4.ui.workbench.renderers.swt.DynamicContributionContributionItem but org.ecliplse.ui.workbench is not accessible here to access PlatformUI.getWorkbench().getActivitySupport() due to cyclic dependency.
I need some suggestion on how to achieve this.

@raghucssit raghucssit added the enhancement New feature or request label Aug 25, 2024
raghucssit added a commit to raghucssit/eclipse.platform.ui that referenced this issue Aug 26, 2024
Similar to PluginActionContributionItem we can support activity
filtering of menu item to be shown or not.

see eclipse-platform#2217
raghucssit added a commit to raghucssit/eclipse.platform.ui that referenced this issue Aug 26, 2024
Similar to PluginActionContributionItem we can support activity
filtering of menu item to be shown or not.

see eclipse-platform#2217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant