Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find/replace overlay: replace shell with integrated composite #2099 #2254

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 16, 2024

  1. Find/replace overlay: replace shell with integrated composite eclipse…

    …-platform#2099
    
    The FindReplaceOverlay is currently realized as a separate shell (more
    precisely, a JFace Dialog), which is placed at a proper position on top
    of the workbench shell. This has some drawback:
    - It has to manually adapt to movements of the parent shell or the
    target part/widget
    - It has to manually hide and show depending on visibility changes of
    the target part/widget
    - It does not follow events of the target immediately, i.e., movements
    are always some milliseconds behind, minimize/maximize
    operations/animations are not synchronous etc.
    - It does not locate properly when the platform uses Wayland, as manual
    shell positioning is not possible there
    
    This change replaces the dialog-based implementation of the
    FindReplaceOverlay with an in-place composite-based implementation. A
    composite is created in the target widget and placed relative to this
    composite. In consequence, the overlay automatically follows all move,
    resize, hide/show operations of the target widget.
    
    Fixes eclipse-platform/eclipse.platform.swt#1447
    
    Fixes eclipse-platform#2099
    HeikoKlare committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b6cf9bb View commit details
    Browse the repository at this point in the history